RFR: 8237521: Memory Access API fixes for 32-bit

[Maurizio Cimadamore]

On 28/01/2020 23:31, David Holmes wrote:
> Hi Nick,
>
> On 27/01/2020 4:41 pm, Nick Gasson wrote:
>> Hi David,
>>
>> On 01/25/20 06:34 am, David Holmes wrote:
>>>>
>>>> I've done this here:
>>>>
>>>> http://cr.openjdk.java.net/~ngasson/8237521/webrev.02/
>>>>
>>>> Need to check bytes >= 0 before aligning up so that allocateMemory(-1)
>>>> still throws an IllegalArgumentException.
>>>
>>> That looks good to me.
>>>
>>>> Tested with jdk_foreign and runtime/Unsafe/.
>>>
>>> Probably needs a bit more testing. IIRC the direct buffers use this API
>>> so they would be a good test subject. Or perhaps Maurizio can run this
>>> through our CI tier1-3 before pushing?
>>>
>>
>> I tested again with jdk_core and hotspot_all_no_apps with no new
>> failures.
>>
>> Would you or Maurizio mind sponsoring this for me if your testing is OK?
>
> Sorry, as the bulk of this change is core-libs code you'll need to 
> find a core-libs sponsor.

Since I'm the one who wrote the core-libs part of the memory access API 
- I think that should be enough :-) ?

I'm happy to sponsor, until somebody has objections.

Maurizio

>
> David
>
>>
>> Thanks,
>> Nick
>>