RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Alexey Bakhtin alexey at azul.com
Fri Jul 3 11:32:50 UTC 2020


Hello All,

Thank you for review.

> 1. If the change in java.security.jgss/share/classes/module-info.java is unavoidable, can we create a sub-package for this single class so that we only need to export it?

As suggested by Max I’ve moved TlsChannelBindingImpl class into sub-package, so module-info.java exports TlsChannelBindingImpl only.

> 
> 2. Is GSSContextImpl::setChannelBinding really necessary? I don't know if there are people using null to erase a CB set earlier.

I think these changes could be useful to exclude situations when application trying to set Channel Binding with GSSContext::setChannelBinding and “com.sun.jndi.ldap.tls.cbtype” property altogether. I can remove it, if you think it is not necessary.

Also, I've fixed Exception text and parseType(String prop) parameter name as suggested by Michael.
Unfortunately, I can not completely exclude usage of the literal names because of module import issues. Fixed in the TlsChannelBinding class only.

Webrev: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v10/

Regards
Alexey



More information about the core-libs-dev mailing list