Sponsor Request: 8241097: java/math/BigInteger/largeMemory/SymmetricRangeTests.java requires -XX:+CompactStrings

[Brent Christian]

Adding -XX:+CompactStrings seems reasonable to me.  (And I think it's a 
betters solution than, say, increasing -Xmx to allow running without 
compact strings.)

-Brent

On 3/17/20 10:46 AM, Brian Burkhalter wrote:
> OK, I am fine with that. I’ll leave it open for the moment though in case anyone else has a comment.
> 
> Brian
> 
>> On Mar 17, 2020, at 10:39 AM, Andrew Leonard <andrew_m_leonard at uk.ibm.com> wrote:
>>
>> I see what you mean, but it's not really the point of the the BigInteger test, which is testing for an Arithmetic exception:
>> The problem test is the one for 8021204 which constructs a String of "0"'s 2*31 long! which if you use 2bytes for each "0" is very likely to run out of memory! The problem is a "bug" in the testcase in that it doesn't quite ensure the environment is capable of running the test, by ensuring 1byte per char helps ensure that. Hotspot is that by default. I also suspect OOME is not certain either necessarily.
>>
>> Andrew Leonard
>> Java Runtimes Development
>> IBM Hursley
>> IBM United Kingdom Ltd
>> internet email: andrew_m_leonard at uk.ibm.com
>>
>>
>>
>>
>> From:        Brian Burkhalter <brian.burkhalter at oracle.com>
>> To:        Andrew Leonard <andrew_m_leonard at uk.ibm.com>
>> Cc:        Java Core Libs <core-libs-dev at openjdk.java.net>
>> Date:        17/03/2020 15:48
>> Subject:        [EXTERNAL] Re: Sponsor Request: 8241097: java/math/BigInteger/largeMemory/SymmetricRangeTests.java requires -XX:+CompactStrings
>>
>>
>>
>> To clarify, could the compact strings setting be detected and maybe add another @run tag and expect an OOME? Not sure this is critical.
>>
>> Brian
>>
>> On Mar 17, 2020, at 8:06 AM, Brian Burkhalter <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>>
>> You’re welcome.
>>
>> I see. Let’s leave this hang out a bit for further comment. Also, is a test possible, or a modification of an existing test?
>>
>>
>>
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>