RFR: 8254078: DataOutputStream is very slow post-disabling of Biased Locking [v2]

Aleksey Shipilev shade at openjdk.java.net
Fri Oct 9 12:45:15 UTC 2020


On Wed, 7 Oct 2020 19:06:16 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8254078: DataOutputStream is very slow post-disabling of Biased Locking
>
> test/micro/org/openjdk/bench/java/io/DataOutputStreamTest.java line 62:
> 
>> 60:
>> 61: @BenchmarkMode(Mode.AverageTime)
>> 62: @OutputTimeUnit(TimeUnit.MICROSECONDS)
> 
> Most JMH tests use NANOSECOND for reporting.

The style rule is to use the units that make numbers look sane: not too large (cluttering the output), not too small
(hiding problems in truncation). From the Andrew's benchmark results above, microseconds is what should be used.

-------------

PR: https://git.openjdk.java.net/jdk/pull/542


More information about the core-libs-dev mailing list