RFR: 8254078: DataOutputStream is very slow post-disabling of Biased Locking [v2]

Andrew Haley aph at openjdk.java.net
Mon Oct 12 18:12:31 UTC 2020


On Wed, 7 Oct 2020 19:05:30 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8254078: DataOutputStream is very slow post-disabling of Biased Locking
>
> test/micro/org/openjdk/bench/java/io/DataOutputStreamTest.java line 25:
> 
>> 23:
>> 24: /*
>> 25:
> 
> The historical data will get stale very fast and is very hardware dependent.
> It will continue to exist in the PR, so I think it should be removed from the test.

If you like. I'm following existing practice.

> test/micro/org/openjdk/bench/java/io/DataOutputStreamTest.java line 62:
> 
>> 60:
>> 61: @BenchmarkMode(Mode.AverageTime)
>> 62: @OutputTimeUnit(TimeUnit.MICROSECONDS)
> 
> Most JMH tests use NANOSECOND for reporting.

I suspect that's because of the amount of time for which these other tests are expected to run, not a general principle.

-------------

PR: https://git.openjdk.java.net/jdk/pull/542


More information about the core-libs-dev mailing list