RFR: 8254775: Microbenchmark StringIndexOfChar doesn't compile
Roger Riggs
rriggs at openjdk.java.net
Wed Oct 14 15:21:23 UTC 2020
On Wed, 14 Oct 2020 15:09:59 GMT, Claes Redestad <redestad at openjdk.org> wrote:
> - Illegal use of a unicode codepoint > \uFFFF as a char.
> - Wrong class name.
> - @Benchmark methods shouldn't be static.
>
> Each of these breaks the build, e.g. make build-microbenchmark fails, so it seems the micro was never tested..?
>
> This patch fixes up the micro so it compiles, but makes no guarantees the micro does anything useful.
Thanks for fixing these problems.
-------------
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/661
More information about the core-libs-dev
mailing list