RFR: 8254775: Microbenchmark StringIndexOfChar doesn't compile
Claes Redestad
redestad at openjdk.java.net
Wed Oct 14 15:26:16 UTC 2020
On Wed, 14 Oct 2020 15:13:00 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> - Illegal use of a unicode codepoint > \uFFFF as a char.
>> - Wrong class name.
>> - @Benchmark methods shouldn't be static.
>>
>> Each of these breaks the build, e.g. make build-microbenchmark fails, so it seems the micro was never tested..?
>>
>> This patch fixes up the micro so it compiles, but makes no guarantees the micro does anything useful.
>
> Thanks for fixing these problems.
Thanks for reviewing, @RogerRiggs - hopefully this is the last of 'em
-------------
PR: https://git.openjdk.java.net/jdk/pull/661
More information about the core-libs-dev
mailing list