RFR: 8223187: Investigate setLocale() call in jpackage native launcher

Kevin Rushforth kcr at openjdk.java.net
Sat Sep 12 12:44:26 UTC 2020


On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> setlocale() affects several C functions. We do not use most of these functions. We only using isspace() and toLower().
> Based on how we use it I do not see any needs for setlocale(). After removing it I retested jpackage by changing
> locally on machine and using different language as input parameters for jpackage. No issues found.

Looks good. I confirmed that these are the only two calls to `setlocale` in the jpackage sources.

-------------

Marked as reviewed by kcr (Author).

PR: https://git.openjdk.java.net/jdk/pull/138


More information about the core-libs-dev mailing list