RFR: 8223187: Investigate setLocale() call in jpackage native launcher

Kevin Rushforth kcr at openjdk.java.net
Sat Sep 12 13:03:06 UTC 2020


On Sat, 12 Sep 2020 12:41:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> setlocale() affects several C functions. We do not use most of these functions. We only using isspace() and toLower().
>> Based on how we use it I do not see any needs for setlocale(). After removing it I retested jpackage by changing
>> locally on machine and using different language as input parameters for jpackage. No issues found.
>
> Looks good. I confirmed that these are the only two calls to `setlocale` in the jpackage sources.

Note: the title of the JBS bug was updated. Can you update the PR title to match?

-------------

PR: https://git.openjdk.java.net/jdk/pull/138


More information about the core-libs-dev mailing list