RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v3]

[Alexey Semenyuk]

On Tue, 22 Sep 2020 09:20:33 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8231591
>> 
>> - Added MultiLauncherTwoPhaseTest which uses predefine app image with multiple launcher and tests to make sure installer
>>   will create shortcuts for all launchers.
>> - Fixed Linux DesktopIntegration to create shortcuts for additional launcher if we using pre-define app image.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8231591: [TESTBUG] Create additional two phase jpackage tests (revision 2)

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java line 636:

> 634:     private Set<String> namedInitializers;
> 635:     private Map<PackageType, PackageHandlers> packageHandlers;
> 636:     private final List<String> launchersName = new ArrayList();

Would the variable name "launcherNames" be more accurate?

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java line 320:

> 318:     }
> 319:
> 320:     public PackageTest addLauncherName(String name) {

There is no need to make this function public and explicitly call it from tests.
It would be better to add call to this function from AdditionalLauncher.applyTo(PackageTest).

-------------

PR: https://git.openjdk.java.net/jdk/pull/263