RFR: 8231591: [TESTBUG] Create additional two phase jpackage tests [v3]
Alexander Matveev
almatvee at openjdk.java.net
Wed Sep 23 23:08:06 UTC 2020
On Wed, 23 Sep 2020 18:07:18 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8231591: [TESTBUG] Create additional two phase jpackage tests (revision 2)
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java line 320:
>
>> 318: }
>> 319:
>> 320: public PackageTest addLauncherName(String name) {
>
> There is no need to make this function public and explicitly call it from tests.
> It would be better to add call to this function from AdditionalLauncher.applyTo(PackageTest).
But test calls AdditionalLauncher.applyTo(JPackageCommand cmd), which does not have reference to PackageTest. Do you
know why we need two applyTo()?
-------------
PR: https://git.openjdk.java.net/jdk/pull/263
More information about the core-libs-dev
mailing list