RFR: JDK-8277175 : Add a parallel multiply method to BigInteger [v5]

kabutz duke at openjdk.java.net
Wed Dec 15 08:06:59 UTC 2021


On Tue, 30 Nov 2021 23:03:48 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> kabutz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Made forkOrInvoke() method protected to avoid strange compiler error
>
> src/java.base/share/classes/java/math/BigInteger.java line 1878:
> 
>> 1876: 
>> 1877:         @Serial
>> 1878:         private static final long serialVersionUID = 0L;
> 
> I don't think you need to declare these, the instances are never intended to support serialization e.g. in the stream implementation for `AbstractTask` that extends `CountedCompleter` we state:
> 
>  * <p>Serialization is not supported as there is no intention to serialize
>  * tasks managed by stream ops.

Thanks, I see now that it is common for the ForkJoinTasks to be annotated with `@SuppressWarnings("serial")`

Changed

-------------

PR: https://git.openjdk.java.net/jdk/pull/6409


More information about the core-libs-dev mailing list