RFR: JDK-8277175 : Add a parallel multiply method to BigInteger [v5]

kabutz duke at openjdk.java.net
Wed Dec 15 08:50:02 UTC 2021


On Tue, 30 Nov 2021 23:10:39 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> kabutz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Made forkOrInvoke() method protected to avoid strange compiler error
>
> src/java.base/share/classes/java/math/BigInteger.java line 1874:
> 
>> 1872:          */
>> 1873:         private static final int PARALLEL_FORK_THRESHOLD = Integer.getInteger(
>> 1874:                 "java.math.BigInteger.parallelForkThreshold",
> 
> I suspect we don't need this system property, there is no such property for streams. We use `ForkJoinPool.getCommonPoolParallelism()`, which is configurable as an escape hatch.

Agreed. It is easier to add something in if we need it, than to take it out once we have offered it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6409


More information about the core-libs-dev mailing list