RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets

[Daniel Fuchs]

On Fri, 5 Feb 2021 09:52:11 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

> Could I get the following change reviewed please? It fixes a problem (in JEP380) on Windows where some file operations on Unix domain sockets were not working and led to the feature being disabled on Windows 2019 Server in JDK 16. So, the fix re-enables the feature on all versions of Windows that support it.
> 
> The test checks all the file APIs that were affected by the problem. The change touches the code that handles symbolic links in Windows (since they are implemented as NTFS reparse points, like Unix sockets), but I didn't add any specific testing in this area, as I assume the existing unit tests for NIO symbolic links should cover that. If I should add more tests here, then I can do that.
> 
> Thanks,
> Michael

This look reasonable to me - but I am not an expert on windows native APIs.
The test seems good and comprehensive though - I particularly like the fact that it tests for `isDirectory`, `isRegularFile`, `isSymlink` and `isOther`, and that it verifies that the socket file can be deleted in the end.

Please wait for a second opinion before integrating.
Also consider whether to write a release note - since you re-enabling support for some versions of Windows for which it was disabled.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2424