RFR: 8252971: WindowsFileAttributes does not know about Unix domain sockets [v2]

Michael McMahon michaelm at openjdk.java.net
Fri Feb 5 22:28:10 UTC 2021


> Could I get the following change reviewed please? It fixes a problem (in JEP380) on Windows where some file operations on Unix domain sockets were not working and led to the feature being disabled on Windows 2019 Server in JDK 16. So, the fix re-enables the feature on all versions of Windows that support it.
> 
> The test checks all the file APIs that were affected by the problem. The change touches the code that handles symbolic links in Windows (since they are implemented as NTFS reparse points, like Unix sockets), but I didn't add any specific testing in this area, as I assume the existing unit tests for NIO symbolic links should cover that. If I should add more tests here, then I can do that.
> 
> Thanks,
> Michael

Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge branch 'master' into 8252971-socket-attributes
 - update
 - update
 - update
 - update
 - update after Alan's first review
 - Merge branch 'master' into 8252971-socket-attributes
 - test update
 - initial fix for review

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2424/files
  - new: https://git.openjdk.java.net/jdk/pull/2424/files/fb6c719d..b61686f4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2424&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2424&range=00-01

  Stats: 10870 lines in 557 files changed: 6876 ins; 2384 del; 1610 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2424.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2424/head:pull/2424

PR: https://git.openjdk.java.net/jdk/pull/2424


More information about the core-libs-dev mailing list