RFR: JDK-8262199: issue in jli args.c [v2]
Alan Bateman
alanb at openjdk.java.net
Tue Feb 23 19:27:41 UTC 2021
On Tue, 23 Feb 2021 14:04:29 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Small changes
>
> src/java.base/share/native/libjli/args.c line 361:
>
>> 359: if (fptr != NULL) fclose(fptr);
>> 360: exit(1);
>> 361: }
>
> Can you insert a blank line here?
This function is "optionally report, optionally fclose, and then exit". Have you tried reducing it to reportAndExit and fclose inline in expandArgFile to avoid it doing 3 things?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2692
More information about the core-libs-dev
mailing list