RFR: JDK-8262199: issue in jli args.c [v2]

Matthias Baesken mbaesken at openjdk.java.net
Thu Feb 25 08:57:43 UTC 2021


On Tue, 23 Feb 2021 19:24:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> This function is "optionally report, optionally fclose, and then exit". Have you tried reducing it to reportAndExit and fclose inline in expandArgFile to avoid it doing 3 things?

hi Alan ,  thanks for your remark ,  I did not do that because I would need to copy both lines (fclose + exit)  to all callers.
On the other hand I wonder -  wouldn't  it be possible  to avoid the fclose  before the  exit(1)  ?
I assume the closing is done on exit anyway  ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2692


More information about the core-libs-dev mailing list