RFR: JDK-8262199: issue in jli args.c [v2]

[Alan Bateman]

On Thu, 25 Feb 2021 08:54:48 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> This function is "optionally report, optionally fclose, and then exit". Have you tried reducing it to reportAndExit and fclose inline in expandArgFile to avoid it doing 3 things?
>
>> This function is "optionally report, optionally fclose, and then exit". Have you tried reducing it to reportAndExit and fclose inline in expandArgFile to avoid it doing 3 things?
> 
> hi Alan ,  thanks for your remark ,  I did not do that because I would need to copy both lines (fclose + exit)  to all callers.
> On the other hand I wonder -  wouldn't  it be possible  to avoid the fclose  before the  exit(1)  ?
> I assume the closing is done on exit anyway  ?

That sounds okay to me, the process is exiting, as you say.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2692