RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

[Igor Ignatyev]

On Wed, 2 Jun 2021 01:00:53 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> EFH is improved to process cores and get mixed stack traces with jhsdb and native stack traces with gdb/lldb. It might be useful because hs_err doesn't contain info about all threads, sometimes it is even not generated.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spaces updated.

Changes requested by iignatyev (Reviewer).

test/failure_handler/src/share/classes/jdk/test/failurehandler/GathererFactory.java line 32:

> 30: import java.io.FileWriter;
> 31: import java.io.PrintWriter;
> 32: import java.nio.file.Files;

I don't see why we need these 3 new imports.

test/failure_handler/src/share/classes/jdk/test/failurehandler/ToolKit.java line 28:

> 26: import jdk.test.failurehandler.action.ActionSet;
> 27: import jdk.test.failurehandler.action.ActionHelper;
> 28: import jdk.test.failurehandler.action.PatternAction;

redundant import

test/failure_handler/src/share/conf/linux.properties line 62:

> 60: cores=native.gdb
> 61: native.gdb.app=gdb
> 62: native.gdb.args=%java\0-c\0%p\0-batch\0-ex\0thread apply all backtrace

could you please add a comment similar to the one in `common.properties` file?

test/failure_handler/src/share/conf/mac.properties line 71:

> 69: native.lldb.app=lldb
> 70: native.lldb.delimiter=\0
> 71: native.lldb.args=--core\0%p\0%java\0-o\0thread backtrace all\0-o\0quit

could you please add a comment similar to the one in common.properties file?

test/failure_handler/src/share/conf/mac.properties line 72:

> 70: native.lldb.delimiter=\0
> 71: native.lldb.args=--core\0%p\0%java\0-o\0thread backtrace all\0-o\0quit
> 72: native.lldb.params.timeout=3600000

why does `lldb` require an increases timeout, but `gdb` and `jhsdb` do not?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4234