RFR: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes [v5]

[Leonid Mesnik]

On Wed, 9 Jun 2021 08:42:13 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spaces updated.
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/GathererFactory.java line 32:
> 
>> 30: import java.io.FileWriter;
>> 31: import java.io.PrintWriter;
>> 32: import java.nio.file.Files;
> 
> I don't see why we need these 3 new imports.

fixed

> test/failure_handler/src/share/classes/jdk/test/failurehandler/ToolKit.java line 28:
> 
>> 26: import jdk.test.failurehandler.action.ActionSet;
>> 27: import jdk.test.failurehandler.action.ActionHelper;
>> 28: import jdk.test.failurehandler.action.PatternAction;
> 
> redundant import

fixed

> test/failure_handler/src/share/conf/mac.properties line 71:
> 
>> 69: native.lldb.app=lldb
>> 70: native.lldb.delimiter=\0
>> 71: native.lldb.args=--core\0%p\0%java\0-o\0thread backtrace all\0-o\0quit
> 
> could you please add a comment similar to the one in common.properties file?

fixed

> test/failure_handler/src/share/conf/mac.properties line 72:
> 
>> 70: native.lldb.delimiter=\0
>> 71: native.lldb.args=--core\0%p\0%java\0-o\0thread backtrace all\0-o\0quit
>> 72: native.lldb.params.timeout=3600000
> 
> why does `lldb` require an increases timeout, but `gdb` and `jhsdb` do not?

Not sure I remember if there is any reason. I remove it. Let increase it later if it actually needed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4234