RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML [v2]
Naoto Sato
naoto at openjdk.java.net
Fri Jun 18 20:33:47 UTC 2021
On Fri, 18 Jun 2021 04:56:06 GMT, Masanori Yano <myano at openjdk.org> wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the else condition.
>
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
>
> Reflect the review comments
src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java line 1454:
> 1452: writer.write(ch); // no escaping in this case
> 1453: }
> 1454: else
I was suggesting removing the entire comment-out block if it is not needed (and confusing), but I will defer the decision to Joe.
test/jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest1.xml line 4:
> 2: <root>
> 3: <tag1></tag1>
> 4: </root>
Add a new line at the end of the file (and other newly created files too).
-------------
PR: https://git.openjdk.java.net/jdk/pull/4474
More information about the core-libs-dev
mailing list