RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML [v2]

Joe Wang joehw at openjdk.java.net
Fri Jun 18 21:12:31 UTC 2021


On Fri, 18 Jun 2021 20:27:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reflect the review comments
>
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java line 1454:
> 
>> 1452:                     writer.write(ch);  // no escaping in this case
>> 1453:                     }
>> 1454:                     else
> 
> I was suggesting removing the entire comment-out block if it is not needed (and confusing), but I will defer the decision to Joe.

I agree. It's very obsolete. The comment-out block from line 1445 to 1454 can be removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4474


More information about the core-libs-dev mailing list