RFR: JDK-8262277: java.net.URLClassLoader.getResource throws undocumented IllegalArgumentException [v3]

Craig Andrews github.com+194713+candrews at openjdk.java.net
Fri Mar 5 16:04:27 UTC 2021


On Fri, 5 Mar 2021 15:42:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> I'd prefer if the test checked that findResource returned null and that findResources returned an empty enumeration.

I'll update the test accordingly.

>  think we should be able to find a better name for the test too.
> Do you really want the author tag in the test? I know they exist in some tests but they are impossible to remove, even when tests/code are significantly changed by someone else.

I can rename the test class to be something descriptive and remove the `@author` tag. I was following other tests which is why I did it this way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2662


More information about the core-libs-dev mailing list