RFR: JDK-8262277: java.net.URLClassLoader.getResource throws undocumented IllegalArgumentException [v3]

[Craig Andrews]

On Fri, 5 Mar 2021 15:46:40 GMT, Craig Andrews <github.com+194713+candrews at openjdk.org> wrote:

>> test/jdk/java/net/URLClassLoader/TestBug8262277.java line 30:
>> 
>>> 28:  * @summary Test to see if URLClassLoader.getResource and URLClassLoader.getResources
>>> 29:  * throw IllegalArgumentException
>>> 30:  */
>> 
>> I'd prefer if the test checked that findResource returned null and that findResources returned an empty enumeration. I think we should be able to find a better name for the test too.
>> Do you really want the author tag in the test? I know they exist in some tests but they are impossible to remove, even when tests/code are significantly changed by someone else.
>
>> I'd prefer if the test checked that findResource returned null and that findResources returned an empty enumeration.
> 
> I'll update the test accordingly.
> 
>>  think we should be able to find a better name for the test too.
>> Do you really want the author tag in the test? I know they exist in some tests but they are impossible to remove, even when tests/code are significantly changed by someone else.
> 
> I can rename the test class to be something descriptive and remove the `@author` tag. I was following other tests which is why I did it this way.

I've made the changes you requested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2662