RFR: 8263729: [test] Extend time to wait before destroying child in ProcssBuilder Basic test [v4]
Thomas Stuefe
stuefe at openjdk.java.net
Sat Mar 20 05:57:40 UTC 2021
On Fri, 19 Mar 2021 18:41:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Intermittent failures on Windows in a test of destroying the child warrant extending the time the parent waits after starting the child before destroying the child.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Clarify modification of argument list after creating ProcessBuilder
Looks good to me, if the intent was to fix potential write blockages in the child process (in which case maybe reformulate the issue title).
I'm sorry I derailed your original wait idea, as well as Ioi's ideas of syncing with the child. Both may still be needed after this fix.
Cheers, Thomas
-------------
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3049
More information about the core-libs-dev
mailing list