RFR: 8263729: [test] divert spurious output away from stream under test in ProcessBuilder Basic test [v4]

Roger Riggs rriggs at openjdk.java.net
Mon Mar 22 14:53:41 UTC 2021


On Sat, 20 Mar 2021 05:55:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify modification of argument list after creating ProcessBuilder
>
> Looks good to me, if the intent was to fix potential write blockages in the child process (in which case maybe reformulate the issue title). 
> 
> I'm sorry I derailed your original wait idea, as well as Ioi's ideas of syncing with the child. Both may still be needed after this fix.
> 
> Cheers, Thomas

Thanks for the reviews and the suggestion to redirect the output to the inherited streams.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3049


More information about the core-libs-dev mailing list