RFR: 8263754: HexFormat 'fromHex' methods should be static
Naoto Sato
naoto at openjdk.java.net
Thu Mar 25 21:49:26 UTC 2021
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> A number of HexFormat methods converting from strings to numbers do not use delimiter, prefix, suffix, and uppercase parameters and would be more convenient if the methods were static.
>
> These APIs were added early in JDK 17 and are being updated before GA.
> This PR updates existing uses in the JDK but there may be compiler warnings in non-JDK source files.
>
> public boolean isHexDigit(int);
> public int fromHexDigit(int);
> public int fromHexDigits(java.lang.CharSequence);
> public int fromHexDigits(java.lang.CharSequence, int, int);
> public long fromHexDigitsToLong(java.lang.CharSequence);
> public long fromHexDigitsToLong(java.lang.CharSequence, int, int);
Looks good (with the suggestions by Claes).
-------------
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3205
More information about the core-libs-dev
mailing list