RFR: 8263754: HexFormat 'fromHex' methods should be static

[Claes Redestad]

On Thu, 25 Mar 2021 21:50:46 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 4582:
>> 
>>> 4580:                             int pos = 0;
>>> 4581:                             for (char c: value.toCharArray()) {
>>> 4582:                                 if (!HexFormat.isHexDigit(c)) {
>> 
>> `hexFmt` created on line 4576 appears to be unused after this.
>
> The toHexDigit methods need access to the uppercase/lowercase distinction.
> So there is no plan to change them.
> I'll amend to include the above and re-check for uncaught uses.

Hmm, I missed that unfortunate detail. It looks mis-matched to have `fromHex*` be static while `toHex*` variants aren't.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3205