RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

Attila Szegedi attila at openjdk.java.net
Tue Mar 30 18:16:19 UTC 2021


On Tue, 30 Mar 2021 12:43:18 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Attila Szegedi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains 13 new commits since the last revision:
>> 
>>  - Tidy
>>  - require non null in SimpleBindings
>>  - Simplify SimpleScriptContext.scopes
>>  - Mark fields final where possible
>>  - Deduplicate registerEngineXxx methods
>>  - Misc tidying
>>  - Deduplicate exception reporting
>>  - Lambdify
>>  - Mark fields as final; eliminate now unnecessary init() method.
>>  - Deduplicate engine creation and setup code
>>  - ... and 3 more: https://git.openjdk.java.net/jdk/compare/f378f350...56d89eb2
>
> Marked as reviewed by sundar (Reviewer).

Thank you for the review @sundararajana! Much appreciated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3229


More information about the core-libs-dev mailing list