Integrated: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

Attila Szegedi attila at openjdk.java.net
Tue Mar 30 18:16:20 UTC 2021


On Sat, 27 Mar 2021 15:19:37 GMT, Attila Szegedi <attila at openjdk.org> wrote:

> I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods had a lot of code duplication among themselves, and even within each method. I refactored them into a modern unified implementation. While there I also took the opportunity to introduce `Objects.requireNonNull` in place of null checks followed by NPE throws, mark private fields final where possible, use lambdas for `doPrivileged` block, use `List.of` and `List.copyOf` where possible, and generally sanitize/deduplicate.

This pull request has now been integrated.

Changeset: 2bd80f94
Author:    Attila Szegedi <attila at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2bd80f94
Stats:     227 lines in 5 files changed: 40 ins; 140 del; 47 mod

8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

Reviewed-by: sundar

-------------

PR: https://git.openjdk.java.net/jdk/pull/3229


More information about the core-libs-dev mailing list