RFR: 8261847: performace of java.lang.Record::toString should be improved

Jim Laskey jlaskey at openjdk.java.net
Tue Nov 16 13:07:46 UTC 2021


On Tue, 16 Nov 2021 10:36:46 GMT, Glavo <duke at openjdk.java.net> wrote:

>> src/java.base/share/classes/java/lang/runtime/ObjectMethods.java line 264:
>> 
>>> 262:                 .map(g -> g.type().returnType())
>>> 263:                 .toList()
>>> 264:                 .toArray(new Class<?>[getters.length]);
>> 
>> Why not `new Class[0]`? It's likely to be faster, isn't it?
>
> (I'm not reviewer.)
> 
> I think `.toArray(Class<?>[]::new)` should be better here. `.toList` seems unnecessary.

Class<?>[] types = Stream.of(getters)
                .map(g -> g.type().returnType())
                .toArray(Class<?>[]::new);

-------------

PR: https://git.openjdk.java.net/jdk/pull/6403


More information about the core-libs-dev mailing list