RFR: 8193682: Infinite loop in ZipOutputStream.close() [v13]

Ravi Reddy rreddy at openjdk.java.net
Thu Nov 18 19:09:18 UTC 2021


> Hi all,
> 
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
> 
> Thanks,
> Ravi

Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:

  Added ZipException case to handle failure CopyZipFile.java - Only close the deflater incase of IOException not in ZipException case scenario

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5522/files
  - new: https://git.openjdk.java.net/jdk/pull/5522/files/d9112977..47697f96

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5522&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5522&range=11-12

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5522.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5522/head:pull/5522

PR: https://git.openjdk.java.net/jdk/pull/5522


More information about the core-libs-dev mailing list