RFR: 8193682: Infinite loop in ZipOutputStream.close() [v13]

[Ravi Reddy]

On Thu, 18 Nov 2021 19:09:18 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
>> 
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added ZipException case to handle failure CopyZipFile.java - Only close the deflater incase of IOException not in ZipException case scenario

Hi All, 

In the latest commit, I have resolved an issue in the case of ZipException in ZipOutputStream.closeEntry().
Now close the deflater in ZipOutputStream.closeEntry() only in case of an IOException and not with ZipException.

Mach5 is green : https://mach5.us.oracle.com/mdash/jobs?search=id:rreddy-jdk-20211118-1708-26358737

Thanks,
Ravi

-------------

PR: https://git.openjdk.java.net/jdk/pull/5522