RFR: JDK-8277175 : Add a parallel multiply method to BigInteger [v3]

David Holmes david.holmes at oracle.com
Thu Nov 25 22:18:57 UTC 2021


On 26/11/2021 4:15 am, kabutz wrote:
> On Thu, 18 Nov 2021 07:26:45 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> kabutz has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Removed JVM flags from benchmark
>>
>> To add my 2c IMO a parallel version of this type absolutely **must** be opt-in. There are simply far too many side-effects of using the FJP and multiple threads to perform the calculation in parallel as if it is just a minor implementation detail. A clear API is 1000x better than a "kill switch".
>>
>> And yes you may still need to expose some kind of tuning knob.
>>
>> David
> 
>> @dholmes-ora has indicated that a [compatibility and specification](https://wiki.openjdk.java.net/display/csr/Main) (CSR) request is needed for this pull request. @kabutz please create a [CSR](https://wiki.openjdk.java.net/display/csr/Main) request for issue [JDK-8277175](https://bugs.openjdk.java.net/browse/JDK-8277175). This pull request cannot be integrated until the CSR request is approved.
> 
> Hi @dholmes-ora thanks - is it possible for me to create a CSR without having access to JIRA? Or do I need to find a sponsor who can help do this on my behalf?

You will need a sponsor to do this for you. I'm a little surprised after 
all these years that you've never even gotten Author role. :)

Cheers,
David

> (Sorry for this newbie question)
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/6409
> 


More information about the core-libs-dev mailing list