RFR: JDK-8277175 : Add a parallel multiply method to BigInteger [v3]

kabutz duke at openjdk.java.net
Fri Nov 26 05:55:03 UTC 2021


On Thu, 18 Nov 2021 07:26:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> kabutz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed JVM flags from benchmark
>
> To add my 2c IMO a parallel version of this type absolutely **must** be opt-in. There are simply far too many side-effects of using the FJP and multiple threads to perform the calculation in parallel as if it is just a minor implementation detail. A clear API is 1000x better than a "kill switch".
> 
> And yes you may still need to expose some kind of tuning knob.
> 
> David

> > Hi @dholmes-ora thanks - is it possible for me to create a CSR without having access to JIRA? Or do I need to find a sponsor who can help do this on my behalf?
> 
> You will need a sponsor to do this for you. I'm a little surprised after all these years that you've never even gotten Author role. :)

Most of my contributions have been finding bugs, rather than fixing them. It's only recently that I've started adding code to the OpenJDK. So, I'm not surprised at all.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6409


More information about the core-libs-dev mailing list