RFR: 8269336: Malformed jdk.serialFilter incorrectly handled [v2]

Jaikiran Pai jpai at openjdk.java.net
Tue Oct 19 14:22:26 UTC 2021


> Can I please get a review for this change which addresses https://bugs.openjdk.java.net/browse/JDK-8269336?
> 
> As noted in that issue, this change will now propagate any exception that occurred during parsing and creation of the filter configured through the `jdk.serialFilter` system property. It will also continue to log those errors, like it previously did.
> 
> A new jtreg test has been introduced to reproduce this issue and verify the fix. 
> 
> Given that invalid values for this system property will now start throwing exception, will this change need a CSR?

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Roger's review suggestion - rethrow the RuntimeException instead of wrapping in ExceptionInInitializerError

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5988/files
  - new: https://git.openjdk.java.net/jdk/pull/5988/files/3169a338..d443049a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5988&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5988&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5988.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5988/head:pull/5988

PR: https://git.openjdk.java.net/jdk/pull/5988


More information about the core-libs-dev mailing list