RFR: 8269336: Malformed jdk.serialFilter incorrectly handled [v2]

Roger Riggs rriggs at openjdk.java.net
Wed Oct 20 13:38:09 UTC 2021


On Tue, 19 Oct 2021 14:22:26 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review for this change which addresses https://bugs.openjdk.java.net/browse/JDK-8269336?
>> 
>> As noted in that issue, this change will now propagate any exception that occurred during parsing and creation of the filter configured through the `jdk.serialFilter` system property. It will also continue to log those errors, like it previously did.
>> 
>> A new jtreg test has been introduced to reproduce this issue and verify the fix. 
>> 
>> Given that invalid values for this system property will now start throwing exception, will this change need a CSR?
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Roger's review suggestion - rethrow the RuntimeException instead of wrapping in ExceptionInInitializerError

LGTM

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5988


More information about the core-libs-dev mailing list