RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v7]

Daniel Fuchs dfuchs at openjdk.java.net
Fri Apr 29 12:39:49 UTC 2022


On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8285452: updated to use lines()

test/lib/jdk/test/lib/util/FileUtils.java line 394:

> 392:             var removed = "";
> 393:             for (int i = fromLine; i <= toLine; i++) {
> 394:                 removed += lines.remove(fromLine - 1).trim();

shouldn't you insert a "\n" ? otherwise concatenating lines "ab" and "c" will be the same as concatenating lines "a" and "bc".

-------------

PR: https://git.openjdk.java.net/jdk/pull/8360


More information about the core-libs-dev mailing list