RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v7]

[Daniel Fuchs]

On Fri, 29 Apr 2022 12:35:59 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8285452: updated to use lines()
>
> test/lib/jdk/test/lib/util/FileUtils.java line 394:
> 
>> 392:             var removed = "";
>> 393:             for (int i = fromLine; i <= toLine; i++) {
>> 394:                 removed += lines.remove(fromLine - 1).trim();
> 
> shouldn't you insert a "\n" ? otherwise concatenating lines "ab" and "c" will be the same as concatenating lines "a" and "bc".

Also calling trim() assumes that white spaces are not significant. This might not be the case in the general case (for instance - think of markdown files were leading spaces are significant).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8360