RFR: 8291978: jpackage: allow to override primary l10n files on Windows

[Alexey Semenyuk]

On Mon, 8 Aug 2022 20:39:33 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> This change is a follow-up to [this comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>> 
>> Override implementation is based on [this comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14510886&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14510886).
>> 
>> As suggested in [this comment](https://github.com/openjdk/jdk/pull/9753#pullrequestreview-1062560789) only English translation is provided for new `resource.wxl-file` label.
>> 
>> `getTempdirectory` utility was moved from `BasicTest` to `WindowsHelper` to be able to provide `--temp` and inspect the contents of `config` dir in verifier. It is not clear if `WindowsHelper` is an appropriate place for this utility (`BasicTest` is not Windows-specific), I've assumed that `--temp` flag itself is only used on Windows.
>> 
>> Testing:
>> 
>>  - [x] enhanced `WinL10nTest` adding checks for `-loc` arguments to `light.exe` and additional `@Parameter` run that overrides one of the primary `.wxl` files
>>  - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 37:
> 
>> 35: resource.post-app-image-script=script to run after application image is populated
>> 36: resource.post-msi-script=script to run after msi file for exe installer is created
>> 37: resource.wxl-file=WiX localization file
> 
> This needs to be added to all WinResources*.properties files.

Good point. We have a discussion of how l10n files should be changed at https://github.com/openjdk/jdk/pull/9753. Can you confirm that if some property is missing in a resource bundle its value is picked from the English resource bundle?

-------------

PR: https://git.openjdk.org/jdk/pull/9780