RFR: 8291978: jpackage: allow to override primary l10n files on Windows [v2]

Alex Kasko akasko at openjdk.org
Mon Aug 8 21:21:08 UTC 2022


On Mon, 8 Aug 2022 21:04:49 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 37:
>> 
>>> 35: resource.post-app-image-script=script to run after application image is populated
>>> 36: resource.post-msi-script=script to run after msi file for exe installer is created
>>> 37: resource.wxl-file=WiX localization file
>> 
>> This needs to be added to all WinResources*.properties files.
>
> Good point. We have a discussion of how l10n files should be changed at https://github.com/openjdk/jdk/pull/9753. Can you confirm that if some property is missing in a resource bundle its value is picked from the English resource bundle?

I've just pushed the commit with EN entries for all files before reading the latest comment. I'll verify the behaviour with `.wxl` and `.properties` files and will comment in this issue.

-------------

PR: https://git.openjdk.org/jdk/pull/9780


More information about the core-libs-dev mailing list