RFR: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks [v2]
Aleksey Shipilev
shade at openjdk.org
Fri Aug 26 14:19:12 UTC 2022
On Fri, 26 Aug 2022 14:06:30 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Touchups
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line 154:
>
>> 152: CachedHash ch = cachedHash;
>> 153: if (ch != null) {
>> 154: if (ch.algorithm.equals(algorithm)) {
>
> The nested if looks a bit strange here, you can change to:
>
> if (ch != null & ch.algorithm.equals(algorithm))
> return ch.hash;
Already done.
-------------
PR: https://git.openjdk.org/jdk/pull/10044
More information about the core-libs-dev
mailing list