RFR: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks [v2]

Aleksey Shipilev shade at openjdk.org
Fri Aug 26 14:23:06 UTC 2022


On Fri, 26 Aug 2022 14:14:12 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Touchups
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line 70:
> 
>> 68:     // ConcurrentMap<String,byte[]>.
>> 69:     //
>> 70:     // For correctness under concurrent updates, we need to wrap the fields
> 
> The comment "If there is a significant ..." reads more like a "TODO" and can be removed.

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/10044


More information about the core-libs-dev mailing list