RFR: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks [v3]

Aleksey Shipilev shade at openjdk.org
Fri Aug 26 14:23:08 UTC 2022


On Fri, 26 Aug 2022 14:06:21 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java line 75:
> 
>> 73:         }
>> 74:         final byte[] hash;
>> 75:         final String algorithm;
> 
> Have you tried using a record? Also can you move the declaration of cachedHash to after the declaration of the record.

Switched to `record`, moved.

-------------

PR: https://git.openjdk.org/jdk/pull/10044


More information about the core-libs-dev mailing list