RFR: JDK-8266670: Better modeling of access flags in core reflection [v2]
Joe Darcy
darcy at openjdk.java.net
Mon Feb 14 22:10:06 UTC 2022
On Mon, 14 Feb 2022 21:10:22 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Fix typo from review feedback.
>> - Merge branch 'master' into JDK-8266670
>> - JDK-8266670: Better modeling of modifiers in core reflection
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 146:
>
>> 144: */
>> 145: SYNTHETIC(0x00001000, false,
>> 146: Set.of(TYPE, FIELD, METHOD, CONSTRUCTOR, ElementType.MODULE, PARAMETER)),
>
> Suggestion:
>
> Set.of(TYPE, FIELD, METHOD, CONSTRUCTOR, MODULE, PARAMETER)),
>
>
> `ElementType.MODULE` is already imported.
Hi Mandy. Since "MODULE" is also an enum constant in the AccessFlag class, the references to ElementType's MODULE need to be qualified.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7445
More information about the core-libs-dev
mailing list