RFR: JDK-8266670: Better modeling of access flags in core reflection [v2]

[Mandy Chung]

On Mon, 14 Feb 2022 22:07:24 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 146:
>> 
>>> 144:      */
>>> 145:     SYNTHETIC(0x00001000, false,
>>> 146:               Set.of(TYPE, FIELD, METHOD, CONSTRUCTOR, ElementType.MODULE, PARAMETER)),
>> 
>> Suggestion:
>> 
>>               Set.of(TYPE, FIELD, METHOD, CONSTRUCTOR, MODULE, PARAMETER)),
>> 
>> 
>> `ElementType.MODULE` is already imported.
>
> Hi Mandy. Since "MODULE" is also an enum constant in the AccessFlag class, the references to ElementType's MODULE need to be qualified.

Ah, right.  I missed this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7445