RFR: 8279921: Dump the .class file in jlink debug mode for any failure during transform() of a plugin

Mandy Chung mchung at openjdk.java.net
Wed Jan 19 03:18:32 UTC 2022


On Wed, 12 Jan 2022 13:45:00 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this change which addresses https://bugs.openjdk.java.net/browse/JDK-8279921?
> 
> The change here builds upon the debugging enhancement that was done in https://github.com/openjdk/jdk/pull/6696 to try and narrow down the problem behind intermittent failures on macos ARM systems. The previous change caught only `IllegalArgumentException` to dump the class file, but as seen in a recent  failure, the exception type itself isn't guaranteed to be the same due to the nature of the issue. So, this commit catches `Exception` to dump the class file. Additionally, the change here also prints out the underlying `ResourcePoolEntry` type to see if that provides any additional hints on why the class content could end being corrupt.

Looks okay to me.

-------------

Marked as reviewed by mchung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7049


More information about the core-libs-dev mailing list