RFR: 8279921: Dump the .class file in jlink debug mode for any failure during transform() of a plugin
Jaikiran Pai
jpai at openjdk.java.net
Thu Jan 20 04:53:50 UTC 2022
On Wed, 12 Jan 2022 13:45:00 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review for this change which addresses https://bugs.openjdk.java.net/browse/JDK-8279921?
>
> The change here builds upon the debugging enhancement that was done in https://github.com/openjdk/jdk/pull/6696 to try and narrow down the problem behind intermittent failures on macos ARM systems. The previous change caught only `IllegalArgumentException` to dump the class file, but as seen in a recent failure, the exception type itself isn't guaranteed to be the same due to the nature of the issue. So, this commit catches `Exception` to dump the class file. Additionally, the change here also prints out the underlying `ResourcePoolEntry` type to see if that provides any additional hints on why the class content could end being corrupt.
Thank you for the review Mandy.
I ran the jdk:tier3 locally to make sure nothing regressed and it went fine:
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
jtreg:test/jdk:tier3 1284 1284 0 0
==============================
TEST SUCCESS
-------------
PR: https://git.openjdk.java.net/jdk/pull/7049
More information about the core-libs-dev
mailing list