RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

Alan Bateman alanb at openjdk.org
Mon Jun 27 06:37:52 UTC 2022


On Mon, 27 Jun 2022 04:50:09 GMT, Thejasvi Voniadka <tvoniadka at openjdk.org> wrote:

> This is a simple change to add some protective code to java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more complete in the event of encountering an any exceptions while running. In the present state, the server.stop() does not get executed in case of encountering a failure. As a result, the test may get hung until a timeout. This fix should address the scenario.
> 
> The test passes on all supported platforms post fix.

test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 89:

> 87:                 server.stop(0);
> 88:             }
> 89:         }

Is there a reason to put the server.start in the try block, I would think this is simpler:


server.start();
try {
    :
} finally {
    server.stop(0);
}

-------------

PR: https://git.openjdk.org/jdk/pull/9293


More information about the core-libs-dev mailing list