RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v2]
Thejasvi Voniadka
tvoniadka at openjdk.org
Mon Jun 27 10:58:52 UTC 2022
On Mon, 27 Jun 2022 06:34:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Thejasvi Voniadka has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
>
> test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 89:
>
>> 87: server.stop(0);
>> 88: }
>> 89: }
>
> Is there a reason to put the server.start in the try block, I would think this is simpler:
>
>
> server.start();
> try {
> :
> } finally {
> server.stop(0);
> }
Thank you @jaikiran , @AlanBateman for your reviews. I have updated the patch with your inputs.
-------------
PR: https://git.openjdk.org/jdk/pull/9293
More information about the core-libs-dev
mailing list